Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VictoriaMetrics #9479

Merged
merged 11 commits into from
Nov 21, 2023
Merged

Add VictoriaMetrics #9479

merged 11 commits into from
Nov 21, 2023

Conversation

sh-cho
Copy link
Contributor

@sh-cho sh-cho commented Sep 3, 2023 •
edited by adamrusted
Loading

victoriametrics

Issue: closes #9801

GitHub Stars: GitHub Repo stars

https://github.com/VictoriaMetrics/VictoriaMetrics

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Sep 3, 2023
adamrusted
adamrusted requested changes Sep 3, 2023
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably update the source for this one, and maybe use the purple/orange from the homepage as a brand colour?
When you update the source, probably best re-generating the icon also.

Would you be able to have another look at this one @sh-cho? 🙏

_data/simple-icons.json Outdated Show resolved Hide resolved
@sh-cho sh-cho requested a review from adamrusted September 4, 2023 11:57
@adamrusted
Copy link
Member

And we're back to the linter being awfully specific.
Apologies @sh-cho - could you have another look at this one? If you pull the latest version, the npm run svglint command should actually work locally...

@sh-cho
Copy link
Contributor Author

sh-cho commented Sep 4, 2023 •
edited
Loading

@adamrusted ok :)

Hmm why inkscape makes extra 0.001 height? interesting..

@sh-cho
Copy link
Contributor Author

sh-cho commented Sep 5, 2023

Test is failed since GitHub API is not working well... (https://www.githubstatus.com/incidents/c8zjb9351hlc)

@PeterShaggyNoble
Copy link
Member

Are you still working on this one, @sh-cho?

@sh-cho
Copy link
Contributor Author

sh-cho commented Nov 21, 2023 •
edited
Loading

@PeterShaggyNoble Sorry I forgot 🥲
I updated. can you check?

Oh I checked svglint failed. I'm modifying now.

@sh-cho sh-cho marked this pull request as draft November 21, 2023 15:57
@sh-cho sh-cho marked this pull request as ready for review November 21, 2023 16:07
@sh-cho sh-cho requested a review from adamrusted November 21, 2023 16:22
@adamrusted adamrusted merged commit 79e8365 into simple-icons:develop Nov 21, 2023
3 checks passed
@github-actions github-actions bot mentioned this pull request Nov 26, 2023
Merged
mondeja added a commit that referenced this pull request Nov 26, 2023
@mondeja
Release 69 new icons and 7 updated icons and 45 removed icons (v10.0.0)
bac6a1d 
# New Icons

- Alamy (#9717)
- AlmaLinux (#9796)
- avianca (#9899)
- Basic Attention Token (#9725)
- Bevy (#7076)
- BitComet (#9563)
- Blockbench (#8060)
- BNB Chain (#9724)
- Boosty (#8897)
- Canvas (#9384)
- CBC (#9881)
- Celestron (#9898)
- Chedraui (#9568)
- Clerk (#9417)
- Crew United (#9354)
- Custom Ink (#9903)
- Depositphotos (#9714)
- Dreamstime (#9716)
- Drizzle (#9606)
- Expedia (#9912)
- Fineco (#9495)
- Google Cloud Spanner (#9472)
- Google Dataflow (#9450)
- Google Dataproc (#9451)
- Google Pub/Sub (#9466)
- Google Tasks (#9580)
- GSMArena.com (#8276)
- Headphone Zone (#9744)
- JitPack (#7701)
- Kick (#8910)
- L'Équipe (#7857)
- LibreOffice Base (#9595)
- Loot Crate (#9875)
- Mahindra (#9908)
- Mailtrap (#8267)
- Medusa (#8324)
- Microsoft Store (#8802)
- NHL (#9887)
- Nordic Semiconductor (#9877)
- NSIS (#7333)
- Odoo (#6980)
- openHAB (#8548)
- OpenTofu (#9607)
- OPPO (#9556)
- Payhip (#8247)
- Phosphor Icons (#9747)
- Pi Network (#9890)
- Pine Script (#9914)
- Polestar (#9627)
- Polygon (#9723)
- PrepBytes (#9904)
- Raycast (#8987)
- Refine (#8842)
- Rive (#9878)
- RTM (#8066)
- Sam's Club (#9577)
- Session (#8246)
- Slint (#9682)
- StockX (#9889)
- Toll (#8203)
- TON (#8249)
- TradingView (#8809)
- Upptime (#9732)
- VictoriaMetrics (#9479)
- Vivint (#9882)
- W3Schools (#9326)
- WazirX (#9742)
- WezTerm (#7774)
- ZebPay (#9743)

# Updated Icons

- Appwrite (#9864)
- B&R Automation (#9338)
- C# (#9528)
- Clubhouse (#9328)
- Hyundai (#9653)
- Proton Mail (#7793)
- Proton VPN (#7795)

# Removed Icons

- (ISC)² (#9390)
- Ableton Live (#9306)
- Acclaim (#9301)
- AddThis (#9371)
- Anchor (#9302)
- AngelList (#9303)
- Angular Universal (#9832)
- AngularJS (#9304)
- Ask Ubuntu (#9294)
- Atom (#9305)
- Badgr (#9336)
- Bath ASU (#9341)
- BBC (#9870)
- BBC iPlayer (#9870)
- byte (#9337)
- Code Review (#9294)
- Deezer (#9856)
- Forestry (#9108)
- Hurriyetemlak (#9706)
- Hyperledger (#9655)
- Jenkins X (#9640)
- JFrog Bintray (#9641)
- LGTM (#9488)
- MediaTemple (#9534)
- Microsoft Office (#9896)
- OpenTF (#9607)
- Sendinblue (#9068)
- SonarSource (#7801)
- Sourcegraph (#9258)
- TNT (#9838)
- Twoo (#9509)
- Untangle (#9459)
- Uploaded (#9837)
- W3C (#9885)
- webhint (#9370)
- WhiteSource (#9369)
- Windi CSS (#9250)
- Winmate (#9367)
- Xilinx (#9190)
- Yahoo! (#9861)
- YOLO (#9836)
- YourTravel.TV (#9182)
- Z-Wave (#9180)
- Zend Framework (#9133)
- ZeroMQ (#9366)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrusted adamrusted adamrusted approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request: Victoria Metrics
3 participants
@sh-cho @adamrusted @PeterShaggyNoble