-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Actix icon #9461
Add Actix icon #9461
Conversation
@IamRezaMousavi is there an SVG version of the icon available on the website? All I can see are PNGs... |
No, I converted the site icon from png to svg format |
@adamrusted What do I need to do? |
@IamRezaMousavi, could you let us know which file you based your icon on, please? So we're comparing like with like. |
@PeterShaggyNoble please see the related issue (#8453):
|
Thanks, @IamRezaMousavi. You're right, I should have checked the issue first! If I had, I would have seen that this one is currently beyond our scope on rank alone, and that it's only within our current scope on the number of stars its primary repo. However, as we are in the process of reviewing our metrics, particularly to either remove or downplay GitHub stars, I'm going to label this as
assessing
If you, or @QuestionableProject, could provide us with another metric illustrating its popularity in the meantime, though, then we can proceed with reviewing this PR. |
You can see https://crates.io/crates/actix-web |
That looks like a good indicator to me, @IamRezaMousavi and puts it on a par with the currently proposed minimum downloads for npm. Would any of the other @simple-icons/maintainers agree that this is popular based on that data? Or should we discuss crates.io downloads further as part of our proposed new metrics first? |
Looks pretty good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On to reviewing, so 😁 Nice work on this one, @IamRezaMousavi; the differences are mostly minor, which is to be expected with a manual vectorisation, but could you see if you could get the upper part of yours (in red) to line up a little better with the original?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating, @IamRezaMousavi, but those differences look more pronounced to me now, unfortunately. Of the 2 versions you've tried so far, I think the first is probably our better option if that's as close as you can get 👍🏻
In the interests of moving this along, I've reverted the SVG to the previous version. But I'd like one of the other @simple-icons/maintainers to have a look over it before proceeding. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now 🎉
Thanks everyone that works on it!
# New Icons - Actix (#9461) (@IamRezaMousavi) - Appium (#10419) (@service-paradis) - Better Stack (#10233) (@PeterShaggyNoble) - Braintree (#10234) (@PeterShaggyNoble) - Bungie (#10357) (@PeterShaggyNoble) - Burp Suite (#10120) (@PeterShaggyNoble) - Cloudron (#8085) (@simrahnb) - Codefresh (#10327) (@PeterShaggyNoble) - Excalidraw (#10241) (@PeterShaggyNoble) - Formspree (#10385) (@service-paradis) - Gojek (#10363) (@Mvlprem) - Google Display & Video 360 (#10042) (@PratyushJayachandran) - HiveMQ (#10393) (@jeoooo) - Keenetic (#10275) (@PeterShaggyNoble) - KNIME (#10370) (@BenHur28) - Kununu (#10356) (@Mvlprem) - LintCode (#10422) (@Mvlprem) - Namu Wiki (#10328) (@PeterShaggyNoble) - Neptune (#10316) (@PeterShaggyNoble) - Nexus Mods (#10313) (@stefanobartoletti) - Porkbun (#10247) (@PeterShaggyNoble) - qbittorrent (#9596) (@21st-centuryman) - Roll20 (#10425) (@garbg) - RustDesk (#10319) (@PeterShaggyNoble) - Typst (#10399) (@Mvlprem) - Western Union (#10383) (@Mvlprem) # Updated Icons - Accenture (#10424) (@garbg) - GitBook (#10390) (@service-paradis) - Grammarly (#10416) (@adamrusted) - Ruff (#10342) (@PeterShaggyNoble)) # New Icons - Actix (#9461) (@IamRezaMousavi) - Appium (#10419) (@service-paradis) - Better Stack (#10233) (@PeterShaggyNoble) - Braintree (#10234) (@PeterShaggyNoble) - Bungie (#10357) (@PeterShaggyNoble) - Burp Suite (#10120) (@PeterShaggyNoble) - Cloudron (#8085) (@simrahnb) - Codefresh (#10327) (@PeterShaggyNoble) - Excalidraw (#10241) (@PeterShaggyNoble) - Formspree (#10385) (@service-paradis) - Gojek (#10363) (@Mvlprem) - Google Display & Video 360 (#10042) (@PratyushJayachandran) - HiveMQ (#10393) (@jeoooo) - Keenetic (#10275) (@PeterShaggyNoble) - KNIME (#10370) (@BenHur28) - Kununu (#10356) (@Mvlprem) - LintCode (#10422) (@Mvlprem) - Namu Wiki (#10328) (@PeterShaggyNoble) - Neptune (#10316) (@PeterShaggyNoble) - Nexus Mods (#10313) (@stefanobartoletti) - Porkbun (#10247) (@PeterShaggyNoble) - qbittorrent (#9596) (@21st-centuryman) - Roll20 (#10425) (@garbg) - RustDesk (#10319) (@PeterShaggyNoble) - Typst (#10399) (@Mvlprem) - Western Union (#10383) (@Mvlprem) # Updated Icons - Accenture (#10424) (@garbg) - GitBook (#10390) (@service-paradis) - Grammarly (#10416) (@adamrusted) - Ruff (#10342) (@PeterShaggyNoble)
Issue: closes #8453
18.4k GitHub ⭐
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24