Skip to content

Commit

Permalink
removed cookieSyncDelay from config since we have more configurat…
Browse files Browse the repository at this point in the history
…ion options now with the `userSync` object (prebid#3142)
  • Loading branch information
thewizarodofoz authored and jsnellbaker committed Oct 9, 2018
1 parent 3fec73f commit c3432e5
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 11 deletions.
10 changes: 0 additions & 10 deletions src/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ const utils = require('./utils');
const DEFAULT_DEBUG = false;
const DEFAULT_BIDDER_TIMEOUT = 3000;
const DEFAULT_PUBLISHER_DOMAIN = window.location.origin;
const DEFAULT_COOKIESYNC_DELAY = 100;
const DEFAULT_ENABLE_SEND_ALL_BIDS = true;
const DEFAULT_DISABLE_AJAX_TIMEOUT = false;

Expand Down Expand Up @@ -84,15 +83,6 @@ export function newConfig() {
this._publisherDomain = val;
},

// delay to request cookie sync to stay out of critical path
_cookieSyncDelay: DEFAULT_COOKIESYNC_DELAY,
get cookieSyncDelay() {
return $$PREBID_GLOBAL$$.cookieSyncDelay || this._cookieSyncDelay;
},
set cookieSyncDelay(val) {
this._cookieSyncDelay = val;
},

// calls existing function which may be moved after deprecation
_priceGranularity: GRANULARITY_OPTIONS.MEDIUM,
set priceGranularity(val) {
Expand Down
1 change: 0 additions & 1 deletion src/prebid.js
Original file line number Diff line number Diff line change
Expand Up @@ -667,7 +667,6 @@ $$PREBID_GLOBAL$$.getConfig = config.getConfig;
* @param {boolean} options.enableSendAllBids Turn "send all bids" mode on/off. Example: `pbjs.setConfig({ enableSendAllBids: true })`.
* @param {number} options.bidderTimeout Set a global bidder timeout, in milliseconds. Example: `pbjs.setConfig({ bidderTimeout: 3000 })`. Note that it's still possible for a bid to get into the auction that responds after this timeout. This is due to how [`setTimeout`](https://developer.mozilla.org/en-US/docs/Web/API/WindowOrWorkerGlobalScope/setTimeout) works in JS: it queues the callback in the event loop in an approximate location that should execute after this time but it is not guaranteed. For more information about the asynchronous event loop and `setTimeout`, see [How JavaScript Timers Work](https://johnresig.com/blog/how-javascript-timers-work/).
* @param {string} options.publisherDomain The publisher's domain where Prebid is running, for cross-domain iFrame communication. Example: `pbjs.setConfig({ publisherDomain: "https://www.theverge.com" })`.
* @param {number} options.cookieSyncDelay A delay (in milliseconds) for requesting cookie sync to stay out of the critical path of page load. Example: `pbjs.setConfig({ cookieSyncDelay: 100 })`.
* @param {Object} options.s2sConfig The configuration object for [server-to-server header bidding](http://prebid.org/dev-docs/get-started-with-prebid-server.html). Example:
* @alias module:pbjs.setConfig
* ```
Expand Down

0 comments on commit c3432e5

Please sign in to comment.