Updates for python free threading#403
Merged
jcapriot merged 15 commits intosimpeg:mainfrom Oct 2, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #403 +/- ##
==========================================
+ Coverage 86.65% 86.81% +0.16%
==========================================
Files 91 91
Lines 18769 18802 +33
Branches 2119 2119
==========================================
+ Hits 16264 16323 +59
+ Misses 1820 1801 -19
+ Partials 685 678 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This reverts commit 686f7ac.
Hasn't really been working well, and it doesn't work in 3.13 anyways.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only place free threading should throw us an issue is on modifying the structure of the
TreeMesh, as multiple concurrent calls to arefinefunction will modify a c++mapwhich is not a thread safe operation. This PR adds a cython mutex lock to the locations that modify the structure of the mesh, and then marks our.pyxextension modules as safe for free threading.