Merged
Conversation
Add a new `cell_bounds` property to `TensorMesh` that returns the bounds of each cell in the mesh. This implements a faster way to obtain the bounds of each cell in the mesh than trying to access them through `TensorCell.bounds`.
Member
|
don't worry too much about updating the CI build stuff at the moment, I've almost got it put back together. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #366 +/- ##
==========================================
+ Coverage 86.06% 86.12% +0.05%
==========================================
Files 90 90
Lines 18478 18494 +16
Branches 2968 2089 -879
==========================================
+ Hits 15904 15928 +24
Misses 1882 1882
+ Partials 692 684 -8 ☔ View full report in Codecov by Sentry. |
Instead of building the nodes from scratch with meshgrid, use the existing `cell_centers` and `h_gridded` properties of the `TensorMesh`.
jcapriot
requested changes
Oct 12, 2024
Co-authored-by: Joseph Capriotti <josephrcapriotti@gmail.com>
Member
Author
|
@jcapriot I think this is ready. Feel free to merge if you think so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new
cell_boundsproperty toTensorMeshthat returns the bounds of each cell in the mesh. This implements a faster way to obtain the bounds of each cell in the mesh than trying to access them throughTensorCell.bounds.