Skip to content

Replace hanging CurviMesh in docstring for CurvilinearMesh#358

Merged
jcapriot merged 2 commits intosimpeg:mainfrom
omid-b:omid-b-patch-1
Sep 1, 2024
Merged

Replace hanging CurviMesh in docstring for CurvilinearMesh#358
jcapriot merged 2 commits intosimpeg:mainfrom
omid-b:omid-b-patch-1

Conversation

@omid-b
Copy link
Contributor

@omid-b omid-b commented Apr 29, 2024

Description for Squash and Merge

Replace CurviMesh for CurvilinearMesh in the text of the mesh overview page.

@codecov
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.76%. Comparing base (2cb2ff4) to head (6dc7379).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #358   +/-   ##
=======================================
  Coverage   85.76%   85.76%           
=======================================
  Files          88       88           
  Lines       18654    18654           
  Branches     2959     2959           
=======================================
  Hits        15998    15998           
  Misses       1996     1996           
  Partials      660      660           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@santisoler
Copy link
Member

Thanks a lot @omid-b for the contribution! Nice catch of that typo!

This is ready to be merged. The tests failing in CI are surely unrelated to your change, so don't worry about them.

I'll add a description to your PR and change its title. Hope you don't mind, and feel free to edit as you please.

Thanks again!

@santisoler santisoler changed the title Update 1_mesh_overview.py Replace hanging CurviMesh in docstring for CurvilinearMesh Apr 30, 2024
@omid-b
Copy link
Contributor Author

omid-b commented Apr 30, 2024

Thank you very much for your reply and adding a better description of the PR @santisoler; it is certainly better descriptive now.

Copy link
Member

@jcapriot jcapriot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@jcapriot jcapriot merged commit ffd4e04 into simpeg:main Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants