Skip to content

Expose TreeMesh geometric intersections used for refine functions.#356

Merged
jcapriot merged 22 commits intosimpeg:mainfrom
jcapriot:tree_intersections
Oct 10, 2024
Merged

Expose TreeMesh geometric intersections used for refine functions.#356
jcapriot merged 22 commits intosimpeg:mainfrom
jcapriot:tree_intersections

Conversation

@jcapriot
Copy link
Member

This PR unifies (and exposes) the geometric intersection tests used by the refine functionalities. The goal is to allow the user to see which cells actually intersected those geometric objects and use them to search for things.

This will expose operations to find cells that intersect with a

It makes use of C++ templates and classes to reduce the repeated code for each of the different geometric objects.

@codecov
Copy link

codecov bot commented Apr 13, 2024

Codecov Report

Attention: Patch coverage is 94.54545% with 24 lines in your changes missing coverage. Please review.

Project coverage is 86.06%. Comparing base (c394964) to head (d1caf10).
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
discretize/mixins/mesh_io.py 52.00% 5 Missing and 7 partials ⚠️
discretize/tests.py 88.52% 3 Missing and 4 partials ⚠️
tests/base/test_volume_avg.py 97.50% 1 Missing and 1 partial ⚠️
discretize/tree_mesh.py 50.00% 1 Missing ⚠️
tests/tree/test_intersections.py 99.29% 0 Missing and 1 partial ⚠️
tests/tree/test_tree_io.py 97.72% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
- Coverage   86.29%   86.06%   -0.23%     
==========================================
  Files          89       90       +1     
  Lines       18726    18478     -248     
  Branches     2961     2968       +7     
==========================================
- Hits        16159    15904     -255     
- Misses       1881     1882       +1     
- Partials      686      692       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jcapriot jcapriot merged commit 1ab5e9a into simpeg:main Oct 10, 2024
@jcapriot jcapriot deleted the tree_intersections branch October 10, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

get_cells_along_line method not robust for tree mesh

1 participant