Skip to content

Replace deprecated Numpy's product by prod#347

Merged
santisoler merged 1 commit intosimpeg:mainfrom
prisae:product
Feb 20, 2024
Merged

Replace deprecated Numpy's product by prod#347
santisoler merged 1 commit intosimpeg:mainfrom
prisae:product

Conversation

@prisae
Copy link
Member

@prisae prisae commented Feb 20, 2024

Resolve

DeprecationWarning: product is deprecated as of NumPy 1.25.0, and will be removed in NumPy 2.0. Please use prod instead.

@codecov
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4f1e334) 85.12% compared to head (85de326) 85.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #347   +/-   ##
=======================================
  Coverage   85.12%   85.12%           
=======================================
  Files          36       36           
  Lines        8408     8408           
=======================================
  Hits         7157     7157           
  Misses       1251     1251           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@santisoler santisoler changed the title Replace deprecated fct product by prod Replace deprecated Numpy's product by prod Feb 20, 2024
Copy link
Member

@santisoler santisoler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @prisae! Thanks for the fix! I'm merging this 🚀

@santisoler santisoler merged commit c4249f4 into simpeg:main Feb 20, 2024
@prisae prisae deleted the product branch June 26, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants