Add cell_nodes property to TensorMesh#333
Merged
santisoler merged 4 commits intomainfrom Sep 18, 2023
Merged
Conversation
Add a new `cell_nodes` property to `TensorMesh` that mimics the one of `TreeMesh` returning the indices of the nodes that correspond to each cell in the mesh. Add tests for the new feature.
Codecov Report
@@ Coverage Diff @@
## main #333 +/- ##
==========================================
+ Coverage 85.46% 85.47% +0.01%
==========================================
Files 39 39
Lines 11990 12001 +11
==========================================
+ Hits 10247 10258 +11
Misses 1743 1743
|
jcapriot
reviewed
Sep 18, 2023
Add a note illustrating the order in which the indices of the nodes for each cell are returned.
Member
Author
|
@jcapriot I just added some notes about the order of the nodes for each cell. Let me know if you like it.
I just copied and pasted your implementation from the |
jcapriot
approved these changes
Sep 18, 2023
Member
jcapriot
left a comment
There was a problem hiding this comment.
Thanks, looks good to me know!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new
cell_nodesproperty toTensorMeshthat mimics the one ofTreeMeshreturning the indices of the nodes that correspond to each cell in the mesh. Add tests for the new feature.