Skip to content

Face props mass matrices#326

Merged
jcapriot merged 40 commits intomainfrom
face_props_mass_matrices
Jul 18, 2023
Merged

Face props mass matrices#326
jcapriot merged 40 commits intomainfrom
face_props_mass_matrices

Conversation

@dccowan
Copy link
Member

@dccowan dccowan commented Jun 12, 2023

Pull request for face properties mass matrix

@jcapriot
Copy link
Member

jcapriot commented Jun 12, 2023

Did you try this with just the average_edge_to_face matrices? I think those should be all you need (similar to how the inner product matrices use average_edge_to_cell to create themselves).

@dccowan
Copy link
Member Author

dccowan commented Jun 16, 2023

TODO LIST:

  • Averaging matrix from edges to faces for unstructured meshes
  • Face properties matrices for tensor, cyl, tree and unstructured

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #326 (e6c2ce9) into main (3d2b2a5) will increase coverage by 0.04%.
The diff coverage is 88.46%.

@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
+ Coverage   85.42%   85.46%   +0.04%     
==========================================
  Files          39       39              
  Lines       11811    11993     +182     
==========================================
+ Hits        10089    10250     +161     
- Misses       1722     1743      +21     
Impacted Files Coverage Δ
discretize/base/base_tensor_mesh.py 88.53% <ø> (ø)
discretize/base/base_mesh.py 91.49% <88.13%> (-1.47%) ⬇️
discretize/operators/inner_products.py 90.63% <89.06%> (-0.38%) ⬇️

Copy link
Member

@jcapriot jcapriot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more organizational changes to the code.

@jcapriot
Copy link
Member

jcapriot commented Jul 17, 2023

Please remove all of the # NOQA E731 from files in tests that you have added, that error should already be ignored in

tests/*: E731, D,

Copy link
Member

@jcapriot jcapriot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jcapriot jcapriot merged commit 794c2d6 into main Jul 18, 2023
@jcapriot jcapriot deleted the face_props_mass_matrices branch July 18, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants