Add total_nodes method to TreeMeshes#324
Merged
jcapriot merged 5 commits intosimpeg:mainfrom Jun 4, 2023
Merged
Conversation
The new property returns the location of all non hanging and hanging nodes.
Member
|
This should probably be called |
Member
Author
|
I agree that it should follow the convention used on the other methods, so I think it's better to rename it. Nevertheless, I think is nice to name things like |
nodes_all method to TreeMeshestotal_nodes method to TreeMeshes
Codecov Report
@@ Coverage Diff @@
## main #324 +/- ##
=======================================
Coverage 85.15% 85.16%
=======================================
Files 38 38
Lines 11535 11538 +3
=======================================
+ Hits 9823 9826 +3
Misses 1712 1712
|
jcapriot
reviewed
Jun 3, 2023
discretize/tree_mesh.py
Outdated
|
|
||
| Returns | ||
| ------- | ||
| (n_nodes + n_hanging_nodes, dim) numpy.ndarray of float |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new method returns the whole set of nodes in the mesh, including non-hanging and hanging nodes. It comes useful when working together with
cell_nodes.