Skip to content

Feat/simp boundary#318

Merged
jcapriot merged 2 commits intosimpeg:mainfrom
jcapriot:feat/simp_boundary
Apr 26, 2023
Merged

Feat/simp boundary#318
jcapriot merged 2 commits intosimpeg:mainfrom
jcapriot:feat/simp_boundary

Conversation

@jcapriot
Copy link
Member

Add the necessary operators for constructing the edge basis vector function integral on the surface boundaries.
This follows the same steps as the curvilinear setup. For each face, you need to get a transformed x,y,z coordinate frame from the two edge tangents at each node with the face normals, then average these three values together to do the correct dot product operation with a 3 component vector defined on the face itself.

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #318 (666c503) into main (a59c290) will increase coverage by 0.09%.
The diff coverage is 96.55%.

@@            Coverage Diff             @@
##             main     #318      +/-   ##
==========================================
+ Coverage   85.28%   85.38%   +0.09%     
==========================================
  Files          38       38              
  Lines       11352    11405      +53     
==========================================
+ Hits         9682     9738      +56     
+ Misses       1670     1667       -3     
Impacted Files Coverage Δ
discretize/unstructured_mesh.py 99.68% <96.55%> (+0.55%) ⬆️

@jcapriot jcapriot merged commit 276c57d into simpeg:main Apr 26, 2023
@jcapriot jcapriot deleted the feat/simp_boundary branch April 26, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant