Conversation
Codecov Report
@@ Coverage Diff @@
## main #296 +/- ##
==========================================
+ Coverage 84.41% 85.04% +0.62%
==========================================
Files 36 36
Lines 11014 11090 +76
==========================================
+ Hits 9297 9431 +134
+ Misses 1717 1659 -58
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds more refinement functions for tree meshes.
They all are "exact" to floating point precision. Using the Separating Axis Theorem to determine the triangle and tetrahedron intersections.
The triangle and tetrahedron should make it natural to extend to any polyhedron body (Because those can always be broken into multiple triangles/tetrahedrons).
I think the next step is to update the
refine_tree_xyzfunction and split it off into the three individual helper functions (at which point we would deprecaterefine_tree_xyz).