Merged
Conversation
- eliminate standalone calls to initialze tf_header - make transfer function base class init in terms of (decimation level, processing scheme) rather than (tf_header, processing scheme) - add tf_header as @Property of transfer function class - make TransferFunctionHeader an mt_metadata ListDict rather than a standalone class [Issue(s): #109]
- also commented out one test in fix_issue_139 so that all tests will pass for PR [Issue(s): #109]
Codecov Report
@@ Coverage Diff @@
## fix_issue_139 #263 +/- ##
=================================================
- Coverage 77.96% 76.77% -1.20%
=================================================
Files 99 85 -14
Lines 5215 5166 -49
=================================================
- Hits 4066 3966 -100
- Misses 1149 1200 +51
|
replace with method emtf_tf_header in processing class [Issue(s): #109]
Collaborator
Author
|
this finally closes issue #109 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing some tf_header issues encountered while debugging issue 139