Consistent Metadata with updated versions of MTH5 and MT-metadata#239
Merged
Consistent Metadata with updated versions of MTH5 and MT-metadata#239
Conversation
Codecov Report
@@ Coverage Diff @@
## main #239 +/- ##
==========================================
- Coverage 77.62% 77.53% -0.09%
==========================================
Files 101 99 -2
Lines 5470 5493 +23
==========================================
+ Hits 4246 4259 +13
- Misses 1224 1234 +10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…into consistent_metadata
This does not solve the larger issue, but it is intended to allow all tests to pass on github when PKD and SAO are unavailable due to NCEDC communications issues. [Issue(s): #159]
… maybe causing github actions to execute them as tests when imported
Very weird message from github actions associated with memory error (pasted below) However, 2 of 4 python versions passed, 3.6, 3.7, but 3.8, 3.9 failed. iFAILED tests/parkfield/test_process_parkfield_run.py::test_processing - numpy.core._exceptions._ArrayMemoryError: Unable to allocate 14.2 GiB for an array with shape (1900490400,) and data type float64 FAILED tests/parkfield/test_process_parkfield_run.py::test - numpy.core._exceptions._ArrayMemoryError: Unable to allocate 14.2 GiB for an array with shape (1900490400,) and data type float64 FAILED tests/parkfield/test_process_parkfield_run_rr.py::test_processing - numpy.core._exceptions._ArrayMemoryError: Unable to allocate 12.9 GiB for an array with shape (1737962400,) and data type float64 FAILED tests/parkfield/test_process_parkfield_run_rr.py::test - numpy.core._exceptions._ArrayMemoryError: Unable to allocate 12.9 GiB for an array with shape (1737962400,) and data type float64 [Issue(s): #156]
Collaborator
|
The aurora tests are failing for several reasons, which all appear to be because NCEDC is down, but none actually are.
So, the strategy for getting this PR across the line should probably be to review the Auxiliary channel issue. I created an issue#117 in mt_metadata to take a look at this. A few other observations of things that can be improved when this PR is merged:
|
…o make_pkdsao_mth5 taking dataset_id as argument
- [x] simplify FDSNDatasetConfig so it doesn't need additional methods from xml_sandbox. - [x] Drop methods from xml_sandbox now in FDSNDatasetConfig - [x] rename FDSNDatasetConfig to FDSNDataset - [x] Place client method in FDSNDataset - [x] move describe_inventory_stages from xml_sandbox to inventory_review - [x] tidy comments in make_mth5_helpers Issues: [#159]
There are enough examples of these around, and any further development of these tools belongs in mt_metadata. Hopefully, removing this will make code-cov happier
…into consistent_metadata
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Going through and trying to make sure metadata and methods are consistent with updated versions of MTH5 and mt-metadata before I merge them with
master. The update was creating a single metadata object under the hood formth5.timeseries.ChannelTSandmth5.timeseries.RunTSto allow for more self-consistent metadata. To do this an object was created for the list of metadata objects at the level below calledmt_metadata.utils.list_dict.ListDict, which can be indexed as a list or keyed like a dictionary.For example:
Tasks Before Merging