Skip to content

workaround issue #228#230

Merged
kkappler merged 5 commits intomainfrom
workaround_issue_228
Oct 17, 2022
Merged

workaround issue #228#230
kkappler merged 5 commits intomainfrom
workaround_issue_228

Conversation

@kkappler
Copy link
Collaborator

Added a workaround for when timestamps are slightly offset.

@codecov
Copy link

codecov bot commented Oct 15, 2022

Codecov Report

Merging #230 (5345287) into main (eaa17cf) will decrease coverage by 0.14%.
The diff coverage is 29.41%.

@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
- Coverage   77.75%   77.61%   -0.15%     
==========================================
  Files         101      101              
  Lines        5454     5468      +14     
==========================================
+ Hits         4241     4244       +3     
- Misses       1213     1224      +11     
Impacted Files Coverage Δ
aurora/transfer_function/regression/base.py 65.81% <ø> (ø)
aurora/time_series/xarray_helpers.py 67.44% <18.18%> (-17.41%) ⬇️
aurora/pipelines/time_series_helpers.py 73.18% <40.00%> (-0.70%) ⬇️
aurora/transfer_function/kernel_dataset.py 80.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

-update KernelDataset so duration is in mini_summary
-Add better diagnostic messages to issue #228 warnings
@kkappler
Copy link
Collaborator Author

tests passing, some codecov reduction as added handling for unmatched time axes which is not yet covered by tests, but does occur in the Yellowstone dataset for the workshop.

@kkappler kkappler merged commit c58c371 into main Oct 17, 2022
@kkappler kkappler deleted the workaround_issue_228 branch April 1, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant