Skip to content

Test mth5 add phoenix#222

Merged
kkappler merged 24 commits intomainfrom
test_mth5_add_phoenix
Sep 25, 2022
Merged

Test mth5 add phoenix#222
kkappler merged 24 commits intomainfrom
test_mth5_add_phoenix

Conversation

@kujaku11
Copy link
Collaborator

@kujaku11 kujaku11 commented Sep 23, 2022

  • Updated the tests to be sure to close any MTH5 files lingering around.
  • Found that pandas >=1.5 produces a type error when trying to set a DataFrame element as a RunGroup. Forcing requirements to be <1.5 in the setup.py. (python 3.8)
  • Running all tests with mth5 branch add_phoenix
    • All tests pass
  • Found that the expected RMS for the processed data got better (update the expected values or tolerance?)
    • Computed: 2.7060984193323794

    • Expected: 2.713543

    • Difference: 0.00744458066

@codecov
Copy link

codecov bot commented Sep 24, 2022

Codecov Report

Merging #222 (19bcbd1) into main (6c0c63e) will increase coverage by 0.10%.
The diff coverage is 85.45%.

@@            Coverage Diff             @@
##             main     #222      +/-   ##
==========================================
+ Coverage   77.96%   78.07%   +0.10%     
==========================================
  Files         101      101              
  Lines        5374     5442      +68     
==========================================
+ Hits         4190     4249      +59     
- Misses       1184     1193       +9     
Impacted Files Coverage Δ
aurora/time_series/frequency_band.py 68.57% <ø> (-0.45%) ⬇️
setup.py 0.00% <ø> (ø)
aurora/test_utils/synthetic/rms_helpers.py 72.54% <30.00%> (-27.46%) ⬇️
aurora/test_utils/synthetic/make_mth5_from_asc.py 83.01% <90.90%> (ø)
tests/parkfield/test_process_parkfield_run_rr.py 94.44% <90.90%> (+11.83%) ⬆️
aurora/pipelines/process_mth5.py 98.08% <100.00%> (+0.15%) ⬆️
aurora/pipelines/time_series_helpers.py 86.88% <100.00%> (+0.44%) ⬆️
tests/parkfield/make_parkfield_mth5.py 89.28% <100.00%> (+1.28%) ⬆️
tests/parkfield/test_calibrate_parkfield.py 93.93% <100.00%> (+0.83%) ⬆️
tests/parkfield/test_process_parkfield_run.py 95.83% <100.00%> (+0.48%) ⬆️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kkappler kkappler merged commit 21e1e2d into main Sep 25, 2022
@kkappler kkappler deleted the test_mth5_add_phoenix branch April 1, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants