Skip to content

modify to address issue #74#202

Merged
kkappler merged 5 commits intomainfrom
issue_74
Aug 6, 2022
Merged

modify to address issue #74#202
kkappler merged 5 commits intomainfrom
issue_74

Conversation

@kkappler
Copy link
Collaborator

@kkappler kkappler commented Aug 1, 2022

No description provided.

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #202 (60d728d) into main (76bb5be) will increase coverage by 0.88%.
The diff coverage is 95.78%.

@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
+ Coverage   71.21%   72.09%   +0.88%     
==========================================
  Files          99      100       +1     
  Lines        5597     5688      +91     
==========================================
+ Hits         3986     4101     +115     
+ Misses       1611     1587      -24     
Impacted Files Coverage Δ
.../transfer_function/transfer_function_collection.py 87.25% <83.33%> (+7.96%) ⬆️
aurora/config/metadata/channel_nomenclature.py 91.17% <91.17%> (ø)
aurora/test_utils/synthetic/make_mth5_from_asc.py 83.01% <95.45%> (+0.49%) ⬆️
aurora/config/metadata/__init__.py 100.00% <100.00%> (ø)
aurora/config/metadata/processing.py 73.45% <100.00%> (+4.37%) ⬆️
aurora/pipelines/process_mth5.py 98.62% <100.00%> (+2.78%) ⬆️
...ra/test_utils/synthetic/make_processing_configs.py 71.42% <100.00%> (-1.30%) ⬇️
...a/test_utils/synthetic/synthetic_station_config.py 100.00% <100.00%> (ø)
aurora/transfer_function/TTFZ.py 79.48% <100.00%> (+0.53%) ⬆️
tests/synthetic/test_synthetic_driver.py 97.64% <100.00%> (+0.42%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

-Added ChannelNomenclature and channel_nomenclature to config
-weave ChannelNomenclature class into synthetic tests
-added methods for setting default input/output/reference channels to processing
 config (may need mod for 4 channel stations)
-changed channel_nomenclature from kwarg to ard in process_mth5
-modified TTFZ to use ChannelNomenclature class
-removed dependencies on aurora.channel_nomenclature

[Issue(s): #74]
@kkappler kkappler merged commit 0efb86a into main Aug 6, 2022
@kkappler kkappler deleted the issue_74 branch August 6, 2022 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant