Skip to content

Fix issue 175#176

Merged
kkappler merged 6 commits intodevfrom
fix_issue_175
May 13, 2022
Merged

Fix issue 175#176
kkappler merged 6 commits intodevfrom
fix_issue_175

Conversation

@kkappler
Copy link
Collaborator

Modifications in this PR enable a column in the dataset_dataframe (aka run_summary) called "channel_scale_factors".

This should be reviewed in future, as using "channel_scale_factors" in general is a workaround, and shouldn't normally be needed, however, over the past while in dev it has been quite useful in debugging errors in metadata.

The point is that I would like this column to be optional, so it should be tested whether this column is required and if it is then add a note to issue #175 about adding that flexibility

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #176 (eb4b5c7) into dev (9054913) will increase coverage by 0.15%.
The diff coverage is 96.07%.

@@            Coverage Diff             @@
##              dev     #176      +/-   ##
==========================================
+ Coverage   68.85%   69.01%   +0.15%     
==========================================
  Files         104      105       +1     
  Lines        5830     5860      +30     
==========================================
+ Hits         4014     4044      +30     
  Misses       1816     1816              
Impacted Files Coverage Δ
tests/config/test_dataset_dataframe.py 97.29% <ø> (ø)
...ra/test_utils/synthetic/make_processing_configs.py 72.72% <66.66%> (+0.81%) ⬆️
aurora/config/metadata/run.py 74.32% <88.88%> (+2.01%) ⬆️
aurora/config/metadata/station.py 82.81% <100.00%> (+0.84%) ⬆️
aurora/test_utils/synthetic/paths.py 100.00% <100.00%> (ø)
...a/test_utils/synthetic/synthetic_station_config.py 100.00% <100.00%> (ø)
aurora/tf_kernel/dataset.py 69.56% <100.00%> (+1.38%) ⬆️
.../synthetic/test_compare_aurora_vs_archived_emtf.py 97.43% <100.00%> (-0.13%) ⬇️
tests/synthetic/test_synthetic_driver.py 96.66% <100.00%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9054913...eb4b5c7. Read the comment docs.

@kkappler kkappler merged commit 91d77e8 into dev May 13, 2022
@kkappler kkappler deleted the fix_issue_175 branch May 13, 2022 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant