Merged
Conversation
-some cruft removal from process_mth5_dev.py -changed the way that the mth5 obj is assigned in the dataset_df *this change explcitly maps the mth5 obj to the station name -changed config_id for RR synthetic test [Issue(s): #165]
Codecov Report
@@ Coverage Diff @@
## dev #166 +/- ##
==========================================
+ Coverage 66.53% 66.73% +0.19%
==========================================
Files 101 102 +1
Lines 6019 6001 -18
==========================================
Hits 4005 4005
+ Misses 2014 1996 -18
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a test for the synthetic RR processing where the data from the two stations each live in their own mth5 file.
This is an expected use case, and the test is passing.