Skip to content

Remove print statements#136

Merged
kkappler merged 2 commits intomainfrom
clean_docs
Nov 21, 2021
Merged

Remove print statements#136
kkappler merged 2 commits intomainfrom
clean_docs

Conversation

@timronan
Copy link
Collaborator

This branch will remove the extraneous print statements and clean at least the titles of the documentation example notebooks in Aurora.

@timronan
Copy link
Collaborator Author

@kkappler I can't find the print statement that is outputting the path to

aurora/config/emtf_band_setup/bs_test.cfg

It's really annoying and is a random print statement with no context. Do you have any idea what module it is in so we can remove it? I've looked for a while.

@codecov
Copy link

codecov bot commented Nov 20, 2021

Codecov Report

Merging #136 (2b632a8) into main (667b2d2) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
- Coverage   66.14%   66.14%   -0.01%     
==========================================
  Files          70       70              
  Lines        4649     4625      -24     
==========================================
- Hits         3075     3059      -16     
+ Misses       1574     1566       -8     
Impacted Files Coverage Δ
aurora/config/processing_config.py 70.51% <ø> (-0.38%) ⬇️
aurora/pipelines/process_mth5.py 93.89% <ø> (-0.05%) ⬇️
aurora/pipelines/time_series_helpers.py 88.73% <ø> (-0.16%) ⬇️
aurora/pipelines/transfer_function_helpers.py 84.81% <ø> (-0.19%) ⬇️
aurora/time_series/frequency_band_helpers.py 33.33% <ø> (+0.83%) ⬆️
aurora/time_series/windowed_time_series.py 53.12% <ø> (+0.95%) ⬆️
aurora/time_series/windowing_scheme.py 89.25% <ø> (-0.18%) ⬇️
aurora/transfer_function/base.py 92.23% <ø> (-0.08%) ⬇️
aurora/transfer_function/iter_control.py 97.05% <ø> (+4.95%) ⬆️
aurora/transfer_function/regression/TRME.py 74.54% <ø> (+0.43%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 667b2d2...2b632a8. Read the comment docs.

@kkappler
Copy link
Collaborator

@kkappler I can't find the print statement that is outputting the path to

aurora/config/emtf_band_setup/bs_test.cfg

It's really annoying and is a random print statement with no context. Do you have any idea what module it is in so we can remove it? I've looked for a while.

@timronan is that the entire text of the print statement? If not can you paste the full text? It might be:
aurora/pipelines/process_mth5.py:50:
print(f"config path changing from \n{config['mth5_path']} to \n{mth5_path}")

@kkappler kkappler merged commit 13ca04b into main Nov 21, 2021
@kkappler
Copy link
Collaborator

Besides that one leftover statement in the discussion this branch reduces the print statement noise significantly and passes tests so I accepted the pull request.

@timronan timronan deleted the clean_docs branch December 6, 2021 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants