Added support for Serbian characters #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Serbian cyrillic characters. Added Serbian latin characters. Added tests for Serbian characters.
vladholubiev
approved these changes
Apr 22, 2017
|
When will this be merged? |
|
Can we have only the Serbian characters added in this PR? I don't feel comfortable removing characters from other alphabets because quite frankly I don't know any of them. Javascript doesn't have a problem with duplicate keys. And it's not like thousands of duplicate keys, it's just a few. At first it looked to me that some characters were removed from one alphabet in favor of another and I don't want to deal with that type of stuff. I'm not the original author of that peace of code either, so I'm not sure how these alphabets were added in the first place. If anyone can add only the new alphabet I would gladly merge it 👍 |
…bian alphabets. Update .gitignore
|
No problem. |
simov
changed the title
|
Thank you! Published in v1.2.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed duplicate characters
Added Serbian Cyrillic characters.
Added Serbian latin characters.
Added tests for Serbian characters.