Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint and related packages; fix new linting errors #47

Merged
merged 2 commits into from
Dec 17, 2018

Conversation

realityking
Copy link
Contributor

The most significant change is that tests now use strict assertions, legacy assertions were deprecated with Node.js 10.

@simov
Copy link
Owner

simov commented Dec 12, 2018

Thanks, I saw your other PR too. Tests are failing on Node 6 due to missing assert.strict.

@realityking
Copy link
Contributor Author

Oi that's annoying. Two options:

  1. Drop Node 6 from TravisCI
  2. Disable node/no-deprecated-api in test.js

Which do you prefer?

@simov
Copy link
Owner

simov commented Dec 13, 2018

I prefer having the LTS versions for a bit longer, especially while they are still supported. No idea what node/no-deprecated-api would do, is it an ESLint rule?

@realityking
Copy link
Contributor Author

node/no-deprecated-api is the eslint rule that gets triggered. I pushed a version that disables that rule for the test file.

@simov simov merged commit c898267 into simov:master Dec 17, 2018
@realityking realityking deleted the eslint branch December 17, 2018 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants