feat: add "trim" option #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simov
approved these changes
Jun 16, 2021
|
Possible you could cut a new release with this change? |
|
I think the hold-up was what to do about the Armenian support that was merged in. Ship it as-is? Remove it then ship? Or change it a bit and ship? I vote for ship as-is, but any of those are reasonable. |
|
I don't have a strong opinion about the Armenian support either. Whatever approach we pick it will result in some characters not having the required quote. |
OK, if you don't have a strong opinion, then let's ship it as it stands now and we can always revise it later. 1.6.0 published. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #122