fix: remove replacement char from start and end in strict mode #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to fixing the bug, this also removes dynamically generated regular expresions which could result in unexpected behavior when the replacement character is a special character in regulard expressions, such as `.`. Refs: simov#112 (comment)
simov
approved these changes
May 11, 2021
|
Hi, @Trott, thanks for working on this. Can you push the tag and the commit for 1.5.3, I just noticed that it is missing. |
Whoops. Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to fixing the bug, this also removes dynamically generated
regular expresions which could result in unexpected behavior when the
replacement character is a special character in regulard expressions,
such as
..Refs: #112 (comment)