Added Ukrainian characters #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This chars are transliterated differently than in other Cyrillic languages
I deleted the 'ґ' char because it is already in the charmap.json
Trott
approved these changes
May 1, 2021
There was a problem hiding this comment.
Looking at the table of romanization in https://en.wikipedia.org/wiki/Romanization_of_Ukrainian, this conforms with BGN/PCGN 1965, so at least there's an authoritative standard to refer to. Looks good to me.
|
@YegorShtonda Is it OK if I port these changes over to the |
|
Yep, looks good to me as well. |
|
@Trott Yes of course |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This chars are transliterated differently than in other Cyrillic languages