Skip to content

Commit

Permalink
Only add trailing border/padding to the right fragment.
Browse files Browse the repository at this point in the history
We used to always subtract trailing border/padding for every fragment
that shouldn't have it, but this changed for table cells in CL:4303193.
To fix this, make sure that we only include trailing border/padding when
at the fragment that has the block-end edge of the box.

Bug: 1425075
Change-Id: Id7afa2eee764e1a8bb3017a90b212495278fe623
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4345873
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118245}
  • Loading branch information
mstensho authored and pull[bot] committed Feb 22, 2024
1 parent 7f8a42b commit 1822466
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions css/css-break/table/table-cell-border-001.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<!DOCTYPE html>
<link rel="author" title="Morten Stenshorne" href="mailto:mstensho@chromium.org">
<link rel="help" href="https://www.w3.org/TR/css-break-3/#box-splitting">
<link rel="help" href="https://bugs.chromium.org/p/chromium/issues/detail?id=1425075">
<link rel="match" href="../../reference/ref-filled-green-100px-square.xht">
<p>Test passes if there is a filled green square and <strong>no red</strong>.</p>
<div style="columns:2; gap:0; column-fill:auto; width:100px; height:100px; background:red;">
<div style="display:table; width:100%;">
<div style="display:table-cell; border-bottom:50px solid green; background:red;">
<div style="height:150px; background:green;"></div>
</div>
</div>
</div>

0 comments on commit 1822466

Please sign in to comment.