Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scroll margins #134

Merged
merged 3 commits into from
Sep 4, 2021
Merged

Add scroll margins #134

merged 3 commits into from
Sep 4, 2021

Conversation

max-sym
Copy link
Contributor

@max-sym max-sym commented Aug 6, 2021

Changes

  • Made it so that we can define inside margins for scroll, meaning that the lib would start scrolling before the mouse surpasses the very edges of the container;

Motivation

  • I wanted to use it in a rich text editor, the vertical edge of which reached the very bottom of the page, and when I'd put my mouse at the very bottom the container won't scroll. Created this PR to make the user experience more comfortable for bigger containers.

@max-sym max-sym force-pushed the add-scroll-margins branch from 625a7c3 to 0612bfb Compare August 6, 2021 06:52
@simonwep
Copy link
Owner

Sorry for the late reply, I'll give it a review tonight!

@simonwep simonwep self-requested a review August 22, 2021 12:44
Copy link
Owner

@simonwep simonwep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking another week - I'm currently taking a small break. Could you also update the README with the newly added config option?

packages/vanilla/src/types.ts Outdated Show resolved Hide resolved
packages/vanilla/demo/index.ts Outdated Show resolved Hide resolved
packages/vanilla/src/index.ts Outdated Show resolved Hide resolved
@max-sym max-sym requested a review from simonwep August 30, 2021 10:52
@max-sym
Copy link
Contributor Author

max-sym commented Aug 30, 2021

@simonwep fixed everything, you can check now! :)

@simonwep
Copy link
Owner

simonwep commented Sep 4, 2021

I just rebased it and squashed the first 3 commits since they're basically "fixes" for themselves ^^

@simonwep simonwep merged commit 6339917 into simonwep:master Sep 4, 2021
@simonwep
Copy link
Owner

simonwep commented Sep 4, 2021

Thank you for this feature 🎉 Have a nice weekend ^^

@max-sym
Copy link
Contributor Author

max-sym commented Sep 4, 2021

Awesome, thanks have a great weekend you too 🚀🚀🚀

@max-sym
Copy link
Contributor Author

max-sym commented Sep 10, 2021

Hey, @simonwep can this be released? Need it in my project :)

@simonwep
Copy link
Owner

@MaxChu23 Sorry, will do tomorrow!

@max-sym
Copy link
Contributor Author

max-sym commented Sep 10, 2021

Thanks a lot!!!

@simonwep
Copy link
Owner

v3.0.0-beta.10 is released :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants