Fix query command's support for DML #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The failing test I added in the previous commit now passes. Diff best viewed with whitespace ignored (git diff/show -w), as most of the change is indentation for the new "with" block.
tsibley
commented
Jul 8, 2020
Comment on lines
+1129
to
+1131
| assert db.execute_returning_dicts("select * from dogs") == [ | ||
| {"id": 1, "age": 5, "name": "Cleo"}, | ||
| ] |
There was a problem hiding this comment.
In other tests, the order of the expected vs. gotten values in the asserts is reversed. However, pytest expects that the LHS is the gotten value and the RHS is the expected value and its error/debugging messages reflect that.
There was a problem hiding this comment.
I had no idea! I've been habitually doing it the other way round because 1 = a is a syntax error whereas a = 1 is not (a typo for a == 1).
It sounds like I'm going to have to break that habit and switch to actual == expected. Thanks for letting me know!
|
This is an excellent fix, thanks! |
simonw
added a commit
that referenced
this pull request
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for details. I ran into this while investigating another feature/issue.