Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should default to streaming output, if supported by the model, unless --no-stream is passed #25

Closed
simonw opened this issue Jun 15, 2023 · 1 comment
Closed

Should default to streaming output, if supported by the model, unless --no-stream is passed #25

simonw opened this issue Jun 15, 2023 · 1 comment
Labels
enhancement New feature or request
Milestone
0.4

Comments

@simonw
Copy link
Owner

simonw commented Jun 15, 2023

I want to make streaming mode the default - I'm fed up of forgetting to add -s to everything. I don't see any harm in it as a default, people can turn it off with --no-stream if they really want to.

Originally posted by @simonw in #17 (comment)
@simonw simonw added the enhancement New feature or request label Jun 15, 2023
@simonw simonw added this to the 0.4 milestone Jun 15, 2023
@simonw
Copy link
Owner Author

simonw commented Jun 15, 2023

PaLM 2 doesn't support streaming, but GPT 3.5 and 4 do.

@simonw simonw closed this as completed in 1e4a855 Jun 15, 2023
@simonw simonw mentioned this issue Jun 16, 2023
Closed
simonw added a commit that referenced this issue Jun 17, 2023
@simonw
Release 0.4
f9ed733 
Refs #6, #13, #15, #16, #17, #21, #24, #25, #35, #37
@simonw simonw mentioned this issue Jul 1, 2023
Closed
simonw added a commit that referenced this issue Jul 10, 2023
@simonw
Stream by default, added--no-stream option, closes #25
6545ce9 
Also finished the work needed to remove --code, refs #24
simonw added a commit that referenced this issue Jul 10, 2023
@simonw
Release 0.4
2d3d297 
Refs #6, #13, #15, #16, #17, #21, #24, #25, #35, #37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
1 participant
@simonw