fix: remove chunked database download header#2777
Open
suzunn wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Database downloads include both a
Content-Lengthheader and an explicitTransfer-Encoding: chunkedheader. Browsers do not show download progress for that response shape, even though the file size is already known.Closes #2663.
Solution
I removed the manual
Transfer-Encoding: chunkedheader from immutable database downloads and updated the existing download test to assert that the response keepsContent-Lengthwithout settingtransfer-encoding.Testing
uv run ruff check datasette\views\database.py tests\test_html.pyuv run black --check datasette\views\database.py tests\test_html.pygit diff --checkI also ran
uv run pytest tests\test_html.py -k database_download_for_immutable -q. The response assertions completed, but the test fails during Windows temporary directory cleanup withPermissionError: [WinError 32] The process cannot access the file because it is being used by another process; that looks like the existing Windows file-handle cleanup issue tracked separately from this header change.