Skip to content

Speed up detect_fts by 61% #2491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
misrasaurabh1 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Speed up detect_fts by 61% #2491

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d19ac0
⚡️ Speed up function `detect_fts` by 61%
codeflash-ai[bot] Jun 20, 2025
e2944cb
refactor
misrasaurabh1 Jun 20, 2025
0699579
Update datasette/utils/__init__.py
misrasaurabh1 Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 16 additions & 15 deletions datasette/utils/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,28 +593,29 @@ def detect_spatialite(conn):

def detect_fts(conn, table):
"""Detect if table has a corresponding FTS virtual table and return it"""
rows = conn.execute(detect_fts_sql(table)).fetchall()
if len(rows) == 0:
sql = detect_fts_sql()
param = (table, table, table)
row = conn.execute(sql, param).fetchone()
if row is None:
return None
else:
return rows[0][0]
return row[0]


def detect_fts_sql(table):
def detect_fts_sql():
return r"""
select name from sqlite_master
where rootpage = 0
and (
sql like '%VIRTUAL TABLE%USING FTS%content="{table}"%'
or sql like '%VIRTUAL TABLE%USING FTS%content=[{table}]%'
or (
tbl_name = "{table}"
and sql like '%VIRTUAL TABLE%USING FTS%'
)
where rootpage = 0
and (
(sql like '%VIRTUAL TABLE%USING FTS%content="' || ? || '"%')
or (sql like '%VIRTUAL TABLE%USING FTS%content=[' || ? || ']%')
or (
tbl_name = ?
and sql like '%VIRTUAL TABLE%USING FTS%'
)
""".format(
table=table.replace("'", "''")
)
)
limit 1
"""


def detect_json1(conn=None):
Expand Down