0.65 TypeError: AsyncClient.__init__() got an unexpected keyword argument 'app'

[simonw]

Just stared seeing this error today after the release of httpx 0.28.0:

File "/opt/hostedtoolcache/Python/3.11.10/x64/lib/python3.11/site-packages/datasette/app.py", line 1601, in request
    async with httpx.AsyncClient(app=self.app) as client:
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: AsyncClient.__init__() got an unexpected keyword argument 'app'

[simonw]

I fixed this code in main but I never backported the fix to the 0.65 release line. Here's the code at fault:

datasette/datasette/app.py

Lines 1571 to 1573 in 753ddc9

	async def get(self, path, **kwargs):
	async with httpx.AsyncClient(app=self.app) as client:
	return await client.get(self._fix(path), **kwargs)

In main it now looks like this:

datasette/datasette/app.py

Lines 2015 to 2020 in e85517d

	async def _request(self, method, path, **kwargs):
	async with httpx.AsyncClient(
	transport=httpx.ASGITransport(app=self.app),
	cookies=kwargs.pop("cookies", None),
	) as client:
	return await getattr(client, method)(self._fix(path), **kwargs)

[simonw]

I don't think depending on httpx>=0.28.0 is strictly necessary here - in fact it could break things for people who depend on Datasette stable but also have some other dependency which isn't yet ready for the breaking changes in httpx.

(Also the tests just failed because my Pyodide test currently pins to 0.23.0)

[simonw]

Released in 0.65.1.