Fix Windows Unicode encoding errors when writing HTML files#7
Merged
Conversation
On Windows, the default file encoding is cp1252, which cannot encode Unicode characters like emojis. This caused UnicodeEncodeError when writing HTML files containing emoji characters. Fixed by explicitly specifying encoding="utf-8" for all read_text() and write_text() calls on HTML files.
Add encoding="utf-8" to all read_text() and write_text() calls in tests to ensure proper handling of UTF-8 encoded HTML files on Windows.
For windows, refs: - #6
simonw
added a commit
that referenced
this pull request
Dec 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, the default file encoding is cp1252, which cannot encode
Unicode characters like emojis. This caused UnicodeEncodeError when
writing HTML files containing emoji characters.
Fixed by explicitly specifying encoding="utf-8" for all read_text()
and write_text() calls on HTML files.