smurf: Block until stream starts #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This increased timeout came from #147. Back then, the session.status was manually set to running, but only after the call to 'stream_g3_on' in the agent. This meant that check_started would actually block until the stream was enabled. Now that ocs automatically sets the status to running, this no longer works, which is why we need this additional check. check_started should return quickly now, and shouldn't come close to this 60 second timeout.
BrianJKoopman
force-pushed
the
koopman/stream-start-check
branch
from
dd87ffc to
cce0c4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in the commit message for 81d89a3, this actually used to block until stream start. When we changed the behavior of ocs to automatically set
session.status('running')this no longer blocked. Until then, the agent was setting 'running' after the stream was enabled.We need to merge simonsobs/socs#898, but this at least gets an example for the usage up.
Feedback welcome.
Resolves #215.