Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Niagara system and Planck NPIPE #9

Merged
merged 12 commits into from
Oct 7, 2024
Merged

Add Niagara system and Planck NPIPE #9

merged 12 commits into from
Oct 7, 2024

Conversation

msyriac
Copy link
Member

@msyriac msyriac commented Oct 4, 2024

Not adding Penn GPC for now.

@msyriac msyriac marked this pull request as draft October 5, 2024 14:58
@msyriac msyriac changed the title Update systems.py Add Niagara system and Planck NPIPE Oct 5, 2024
@msyriac msyriac marked this pull request as ready for review October 5, 2024 16:00
@msyriac
Copy link
Member Author

msyriac commented Oct 5, 2024

Note that for Planck NPIPE, the split numbers are 1 and 2, rather than 0 and 1. And the map tags are slightly different. But sofind seems flexible enough not to care.

@zatkins2
Copy link
Collaborator

zatkins2 commented Oct 7, 2024

This is all great, thanks for adding.

For Planck, that is good to know. You're right that sofind won't care, but mnms will, because it does iteration over splits in couple places like range(num_splits). simonsobs/mnms#10

Could you also target develop for this PR?

@msyriac msyriac changed the base branch from main to develop October 7, 2024 16:55
@msyriac
Copy link
Member Author

msyriac commented Oct 7, 2024

How do you go about addressing the split number filename mismatch? (I'll work on targeting to develop)

@zatkins2
Copy link
Collaborator

zatkins2 commented Oct 7, 2024

I don't really see a way around cluing mnms to expect some other iterable of splits. So somehow that information would need to be recorded explicitly (e.g., if not added, assume 0-indexed, otherwise, some item in a yaml that just lists out the split iterable). This would likely be an addition to these Planck yamls you just added, but let's worry about that when we know what we want.

@zatkins2 zatkins2 merged commit d63a3b3 into develop Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants