pysmurf-controller: Allow versioneer to determine sodetlib version safely #945
+4
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the determination of
sodetlibversion installed within the pysmurf-controller Docker image. The fix is the same one applied here forpysmurfin one of the base images.Motivation and Context
The permissions were preventing the determination of the sodetlib version due to dubious ownership of the sodetlib repo checkout. This prevented the actual version being used from showing up in this metadata.
How Has This Been Tested?
Before this patch if you run as the
cryo:smurfuser within the container,git statusdoes not work and if you try to determine thesodetlibversion you would get0+unknown:After this patch
git statusworks and the version can be determined.Types of changes
Checklist: