ACU: Fix duplicate status data bug #918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where the timestamp was not properly stored for comparison with the last reading. This bug became relevant due to recent changes that increased the storage rate of status data to 20 Hz from 0.5 Hz.
BrianJKoopman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where the timestamp was not properly stored for comparison with the last reading. This led to duplicate data (including timestamp) being stored for the 'status' info. This has caused bookbinding difficulties for the past few days of SAT data, though it's fairly easy to work around it.
Motivation and Context
This bug became relevant due to recent changes that increased the storage rate of status data to 20 Hz from 0.5 Hz.
I took this opportunity to reorganize and test the "previous vs. current" comparisons on each status read.
How Has This Been Tested?
Tested all changes, for SAT and LAT-like data stuctures, using the ACU simulator server.
Types of changes
Checklist: