ACU: Read out HVAC fields #911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Member
|
Now that #913 is merged, please either rebase or merge in |
mhasself
force-pushed
the
mhasself/acu-hvac
branch
from
0401266 to
8668aca
Compare
BrianJKoopman
requested changes
Aug 6, 2025
Member
BrianJKoopman
left a comment
BrianJKoopman
left a comment
There was a problem hiding this comment.
Looks good, just a few small comments/suggestions.
Member
Author
|
Thanks -- all comments addressed I think. |
BrianJKoopman
approved these changes
Aug 7, 2025
Member
BrianJKoopman
left a comment
BrianJKoopman
left a comment
There was a problem hiding this comment.
Looks good, thanks for the updates!
BrianJKoopman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support readout out of the LAT HVAC dataset.
Motivation and Context
The LAT has a bunch of fans and therometers and stuff. They are critical to maintaining environmental stability, which can affect pointing. This patch provides monitoring of HVAC status. A subsequent patch will enable control of fans and boosters.
How Has This Been Tested?
Tested with simulator, based on a dataset grabbed from real LAT. Confirmed this doesn't mess up SATPs (which don't have HVAC datasets).
Types of changes
Checklist: