Skip to content

Conversation

@mjrand
Copy link
Contributor

@mjrand mjrand commented Jul 30, 2025

Description

Added in query functions and fields for the tc400 turbo pump bearing, electronics, pump bottom, and power stage temperatures.
Added in query functions and fields for the tc400 drive voltage, current, and power.
Added in query functions and fields for the tc400 acceleration.

Motivation and Context

This change adds in extra data fields that will help debug the TC400 temperatures as well as drive voltage+current+power in the future.

How Has This Been Tested?

I ran this agent on daq-dev and was able to read all fields with the correct data type and values for both the SATp1 and LAT turbo controllers.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
    I've updated the doc strings for the agent acq function. (Is there extra documentation somewhere else that needs to be updated?)

@mjrand mjrand requested a review from BrianJKoopman July 30, 2025 05:22
@mjrand mjrand self-assigned this Jul 30, 2025
Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for adding the new responses to the tests! I'm going to push one small change, then we'll get this merged.

@BrianJKoopman BrianJKoopman merged commit 7db35e2 into main Aug 15, 2025
5 checks passed
@BrianJKoopman BrianJKoopman deleted the add_tc400_fields branch August 15, 2025 17:33
@BrianJKoopman BrianJKoopman changed the title Add extra fields to tc400 drivers/agent acq function tc400: Add more fields to agent acq process Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants