ACU: Fix sun avoidance for extended el range #899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Properly handles LAT range, el=-90 through 180. - Fix "sun_time_shift" feature, for testing+debugging, works better - When sun is below horizon, a status indicator is explicitly set. - When boresight is below horizon, a status indicator is set. - Lots of tests for the extended elevation range of LAT.
- Allow el_dodging - el_horizon=0 instead of 10.
Member
BrianJKoopman
left a comment
BrianJKoopman
left a comment
There was a problem hiding this comment.
Looks good to me. Good to see all the added tests! Just a couple of small comments.
Member
Author
Thanks for the careful read! All comments addressed now, I believe. |
BrianJKoopman
approved these changes
Jun 18, 2025
BrianJKoopman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extends sun avoidance code and tests to cover situations where a scope is pointed below horizon level, or in the el > 90 range.
Motivation and Context
The ACU Sun Avoidance code was developed for SAT, considering elevation range (0, 90). The LAT can move through elevations (-90, 180), which presents new challenges.
The most pressing concern was to recognize that the Earth blocks the Sun, so it's always safe to point at el=-90, even at local midnight.
A full examination yielded lots of other edge cases though, such as how to handle cases where the Sun has just set or is just about to rise.
How Has This Been Tested?
I tested this extensively using ACU simulator by tweaking the Sun position into key areas (zenith, sunset, sunrise) and testing status variables and escape behavior. These manual tests led to many, and more pointed unit tests.
Types of changes
Checklist: