Skip to content

Conversation

@dixilo
Copy link
Contributor

@dixilo dixilo commented Jun 6, 2025

Description

Changed the position of publish_to_feed so that acq can also publish cold-junction temperatures of thermocouple amplifier.

Motivation and Context

Previously cold-junction temperatures were not published to feed because of a mistake in the location of the publish_to_feed.
This PR fixes the problem.

How Has This Been Tested?

Not tested yet.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@dixilo dixilo requested a review from BrianJKoopman June 6, 2025 13:48
Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the bug fix!

@BrianJKoopman BrianJKoopman merged commit 269330b into main Jun 6, 2025
5 checks passed
@BrianJKoopman BrianJKoopman deleted the jsuzuki/stimulator/thermometer branch June 6, 2025 16:15
@BrianJKoopman BrianJKoopman changed the title fix: publish cold junction temperature to feed stimulator: Publish cold junction temperature to feed Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants