ACU: Restore and enhance "fromfile" functionality #876
Conversation
- fromfile_scan is now a process rather than a task, because it can run ad infinitum (like generate_scan). - New file format is supported -- pickle-based, so user can pass a dict with the "free_form" and "loopable" options. - _run_track now explicitly sets the ACU profiler and interpolation modes. This will ensure that standard generate_scans are always run with those in the classic way.
mhasself
force-pushed
the
mhasself/acu-fix-fromfile
branch
from
6d5cf7e to
cc82a05
Compare
BrianJKoopman
left a comment
BrianJKoopman
left a comment
There was a problem hiding this comment.
This looks good. I mostly had docstring syntax related comments, but also some questions about looping from files.
BrianJKoopman
left a comment
BrianJKoopman
left a comment
There was a problem hiding this comment.
Sorry, one other general comment related to resolving #864. Does this now "specify what to do with el / corot axes (stop / preset / following)"?
No, but it's a step in right direction. I propose to close that issue and re-open if those features become critical. |
|
Thanks, I believe I've addressed all items. The |
BrianJKoopman
left a comment
BrianJKoopman
left a comment
There was a problem hiding this comment.
Looks good, thanks for the updates!
BrianJKoopman
changed the title
2 participants
(Note this PR includes #865 -- can be rebased once that is merged.)
Description
There are some interface changes here, in fromfile_scan, but that function has not been broadly used and is not implicated in regular observations.
Motivation and Context
Resolves #864.
How Has This Been Tested?
Tested with simulator; tested on LAT to confirm that generate_scan works as before, and also tested a sine-like trajectory for the free_form, fromfile mode.
Types of changes
Checklist: