pysmurf-controller: Bypass smurf instance for RSSI restart #872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianJKoopman
requested changes
May 12, 2025
Member
BrianJKoopman
left a comment
BrianJKoopman
left a comment
There was a problem hiding this comment.
Good catch, just one small request.
tristpinsm
force-pushed
the
tpm/fix-rssi-restart
branch
from
5c663cb to
ecc7275
Compare
BrianJKoopman
approved these changes
May 12, 2025
BrianJKoopman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We found that the
restart_rssiaction fails on a slot that is actually locked-up because this prevents it from instantiating a pysmurf instance, which we had overlooked. This fix bypasses that interface by sending the command directly via EPICS.How Has This Been Tested?
Tested on a locked up slot on the LAT.
Types of changes
Checklist: