ACU Agent: generate_scan waits for settling, before exiting #862
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After it stops uploading points, generate_scan waits for the az to settle at (a) the last commanded position and (b) at velocity zero. Once those conditions are met, the process exits. Previously there was just a flat 10 second wait. There were cases observed where this wasn't long enough.
This does break fromfile_scan. Sorry. That's not used in observations but it's useful so I will get it working again, soon.
Motivation and Context
Resolves a crash seen on SAT where a scan ends, and immediately a new Preset position is commanded (while ProgramTrack is still settling down); the ACU seems to get confused and approach the new target very slowly, which times out the go_to state progress checker.
How Has This Been Tested?
Tested extensively on simulator and also on SATP3 just now. Behaves as desired.
Types of changes
Checklist: