Skip to content

Conversation

@mhasself
Copy link
Member

@mhasself mhasself commented Apr 24, 2025

Description

After it stops uploading points, generate_scan waits for the az to settle at (a) the last commanded position and (b) at velocity zero. Once those conditions are met, the process exits. Previously there was just a flat 10 second wait. There were cases observed where this wasn't long enough.

This does break fromfile_scan. Sorry. That's not used in observations but it's useful so I will get it working again, soon.

Motivation and Context

Resolves a crash seen on SAT where a scan ends, and immediately a new Preset position is commanded (while ProgramTrack is still settling down); the ACU seems to get confused and approach the new target very slowly, which times out the go_to state progress checker.

How Has This Been Tested?

Tested extensively on simulator and also on SATP3 just now. Behaves as desired.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Resolves a crash seen on SAT where a scan ends, and immediately a new
Preset position is commanded (while ProgramTrack is still settling
down); the ACU seems to get confused and approach the new target very
slowly, which times out the go_to state progress checker.
@mhasself mhasself requested a review from BrianJKoopman April 24, 2025 17:02
Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one small question and a request to open an issue for the broken task. Going to go ahead and merge.

@BrianJKoopman BrianJKoopman merged commit 94412e0 into main Apr 28, 2025
5 checks passed
@BrianJKoopman BrianJKoopman deleted the mhasself/acu-ptrack-settling branch April 28, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants