-
Notifications
You must be signed in to change notification settings - Fork 15
Make ibootbarAgent compatible with legacy ibootbar #861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. One small comment on one of the tasks below. Thanks for working through the MIB/SNMP complications to get this working on this agent!
On SNMP version -- I was having a hard time finding it in the manual, but some devices will have a version selection within the UI on the device. Is the IBOOTBAR just so old it doesn't support v2? Or is it just set to v1 by default? (Which is fairly common in my experience.)
I'm not sure what to make of the timeout you posted. Does it show up every time you run with the legacy device. @davidvng might have some insights, as he's worked with many SNMP devices.
Co-authored-by: Brian Koopman <BrianJKoopman@users.noreply.github.com>
SNMP version is written in manual v1.5, top of p7.
Yeah, when I tested it, I saw this every time when I call agent task (snmp.set). |
davidvng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! Overall looks good to me.
As for the SNMP response timeout for the agent tasks, I think it's ok if you've confirmed that it physically changes the state of the correct outlet. Also, one thing to check is the ibootbar SNMP configuration on its webpage. The set command here uses a community_name of "private" by default, but it might be configured to "public" or something else in these ibootbars:
Lines 193 to 194 in dc3fcfc
| if version == 1: | |
| version_object = CommunityData(community_name, mpModel=0) # SNMPv1 |
|
Thanks, I checked it via telnet and the setting seems to match with agent. |
BrianJKoopman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the secondary review @davidvng! Going to merge this. (Ignoring the lack of tests being run, I suspect some strange interaction with the commit via suggestion. And that change was small, and tests ran before that fine.)
Make ibootbarAgent compatible with legecy ibootbar
Description
Make ibootbarAgent compatible with legacy ibootbar. There are differences in SNMP version, MIB. This PR supersedes #860.
Motivation and Context
This legacy iBootBar (iBB-N20) is used in satp3, we tried to swap the iBootBar with agent compatible device, iBoot PDU, but it turned out that it's physically not easy to do. Therefore, we modify the ibootbarAgent to be compatible with legacy ibootbar.
How Has This Been Tested?
Tested by daq-dev. Tested this works for legecy ibootbar, also confirmed this works for iboot-pdu.
One weird point is that the agent tasks works on legacy ibootbar but I see the following timeout failure in log.
Types of changes
Checklist: