Skip to content

Conversation

@ykyohei
Copy link
Contributor

@ykyohei ykyohei commented Apr 6, 2025

Satp3 configured irig for wiregrid encoder, irig was not configured for wiregrids at site before. This PR fixes several bugs we found.

Description

  • Fix typo in irig time conversion
  • Add missing timestamp in rough irig data.
  • Fix irig_fdata. 'quadrature', 'pru_clock', 'reference_degree', 'error' are encoder data not irig data.

Currently encoder shows errors like this
In this state, wiregrid encoder agent induces memory leak. This PR may also improve this.

2025-04-06T20:15:17+0000 Invalid IRIG-B timestamp: 25 96 20 15 16
2025-04-06T20:15:17+0000 Invalid IRIG-B timestamp: 25 96 20 15 15
2025-04-06T20:15:17+0000 Invalid IRIG-B timestamp: 25 96 20 15 14
2025-04-06T20:15:16+0000 while calling from thread
2025-04-06T20:15:16+0000 while calling from thread
2025-04-06T20:15:15+0000 while calling from thread
2025-04-06T20:15:14+0000 while calling from thread
2025-04-06T20:15:14+0000 while calling from thread
2025-04-06T20:15:14+0000 while calling from thread
2025-04-06T20:15:14+0000 while calling from thread
2025-04-06T20:15:14+0000 while calling from thread
2025-04-06T20:15:14+0000 Invalid IRIG-B timestamp: 25 96 20 15 13
2025-04-06T20:15:14+0000 Invalid IRIG-B timestamp: 25 96 20 15 12
2025-04-06T20:15:14+0000 Invalid IRIG-B timestamp: 25 96 20 15 11

image

Motivation and Context

These fixes are necessary to properly acquire irig info.

How Has This Been Tested?

tested at daq-dev for satp3

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Contributor

@sadachi5 sadachi5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your modification.
Just for my understanding, could you let me know what was the reason of the memory leak?

@ykyohei
Copy link
Contributor Author

ykyohei commented Apr 8, 2025

I actually do not understand the cause of memory leak and not sure if this resolves it.

Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@BrianJKoopman BrianJKoopman merged commit 9b5a6eb into main Apr 14, 2025
5 checks passed
@BrianJKoopman BrianJKoopman deleted the wg_enc_fix branch April 14, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants