Skip to content

Conversation

@mhasself
Copy link
Member

Description

For LAT, adds a task to open/close the shutter. Also reads out shutter state vars and saves them in the usual places.

Requires soaculib 0+untagged.187.g3de6ea0 (merged yesterday).

How Has This Been Tested?

Developed on ACU simulator, with datasets set up to match snapshots from LAT ACU.

Also tested on LAT, controlling the real shutter. Compatible with latest ocs-web shutter control widget.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mhasself mhasself requested a review from BrianJKoopman March 25, 2025 19:28
Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a couple of small questions/comments.

@mhasself
Copy link
Member Author

Thanks -- added a warning and fixed the docstring.

@mhasself mhasself requested a review from BrianJKoopman March 31, 2025 18:16
Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, looks good.

@BrianJKoopman BrianJKoopman merged commit a499f44 into main Mar 31, 2025
5 checks passed
@BrianJKoopman BrianJKoopman deleted the mhasself/acu-lat-shutter branch March 31, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants