-
Notifications
You must be signed in to change notification settings - Fork 15
Add KIKUSUI PCR500MA AC power supply agent #818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianJKoopman
requested changes
Jan 24, 2025
Member
BrianJKoopman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks for the PR! A few small comments below. I'm also going to push a commit with some packaging bits. Please pull before making further changes.
Co-authored-by: Brian Koopman <BrianJKoopman@users.noreply.github.com>
BrianJKoopman
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a new agent to operate KIKUSUI's PCR500MA AC power supply.
Motivation and Context
PCR500MA will be used as a power source to the stimulator heater to generate radiation.
Since the device will be connected to the site ethernet and be controlled from daq-pc, it should be included in this socs repository.
How Has This Been Tested?
Test was done using the actual PCR500MA device.
The device was connected to the lab network, and the ocs agent and client were run from a PC also connected to the same network.
Functions in the agent code was tested by checking the display and the light indicator of the device.
Torelance to the ethernet disconection was also tested by just unplugging the cable from the device.
Types of changes
Checklist: