Skip to content

Conversation

@dixilo
Copy link
Contributor

@dixilo dixilo commented Jan 20, 2025

Description

This pull request adds a new agent to operate KIKUSUI's PCR500MA AC power supply.

Motivation and Context

PCR500MA will be used as a power source to the stimulator heater to generate radiation.
Since the device will be connected to the site ethernet and be controlled from daq-pc, it should be included in this socs repository.

How Has This Been Tested?

Test was done using the actual PCR500MA device.
The device was connected to the lab network, and the ocs agent and client were run from a PC also connected to the same network.
Functions in the agent code was tested by checking the display and the light indicator of the device.
Torelance to the ethernet disconection was also tested by just unplugging the cable from the device.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@dixilo dixilo requested a review from BrianJKoopman January 20, 2025 11:00
@dixilo dixilo self-assigned this Jan 20, 2025
@BrianJKoopman BrianJKoopman added hardware: stimulator new agent New OCS agent needs to be created labels Jan 22, 2025
Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for the PR! A few small comments below. I'm also going to push a commit with some packaging bits. Please pull before making further changes.

dixilo and others added 2 commits January 27, 2025 09:39
Co-authored-by: Brian Koopman <BrianJKoopman@users.noreply.github.com>
@dixilo dixilo requested a review from BrianJKoopman January 27, 2025 01:19
@BrianJKoopman BrianJKoopman merged commit a31809c into main Jan 27, 2025
6 checks passed
@BrianJKoopman BrianJKoopman deleted the jsuzuki/stimulator/kikusui_pcr500ma branch January 27, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hardware: stimulator new agent New OCS agent needs to be created

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants