Skip to content

ld-monitor: Remove session.set_status() calls and define protocol in compose example #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrianJKoopman merged 2 commits into from
Jan 6, 2025
Merged

ld-monitor: Remove session.set_status() calls and define protocol in compose example #812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab5c7ef
Remove session.set_status calls, which are automatic now
BrianJKoopman Jan 6, 2025
bebde59
Specify protocol for port mapping
BrianJKoopman Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/agents/ld_monitor.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ An example docker-compose configuration::
image: simonsobs/socs:latest
hostname: ocs-docker
ports:
- "1110:1110"
- "1110:1110/udp"
environment:
- INSTANCE_ID=ld-monitor
- SITE_HUB=ws://127.0.0.1:8001/ws
Expand Down
4 changes: 0 additions & 4 deletions socs/agents/ld_monitor/agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,6 @@ def init_ld_monitor(self, session, params=None):
"{} is already running".format(self.lock.job))
return False, "Could not acquire lock."

session.set_status('starting')

self._connect()
if not self.initialized:
return False, 'Could not connect to LD'
Expand Down Expand Up @@ -315,8 +313,6 @@ def acq(self, session, params=None):
.format(self.lock.job))
return False, "Could not acquire lock."

session.set_status('running')

self.take_data = True

session.data = {"fields": {}}
Expand Down
Loading